Re: Evince threading update

[Jonathan Blandford <jrb redhat com>]

Marco Pesenti Gritti <mpgritti gmail com> writes:

> I'm going to work on these... I looked in it a bit and I think the
> following are the viable solutions on the short term (first release):
>  
> >  * links
> 
> I'm going to create the EvPage abstraction. I think it will avoid code
> duplication. We can access the pixbuf with ev_page_get_pixbuf.
> 
> ev_page_get_link will behave just like ev_document_get_link.

Careful here.  Accessing the pixbuf means something totaly different in
the new branch.  Check out ev-pixbuf-cache.c to see what I mean.

> >  * search
> 
> We need an EvTextPage object/interface with a find method. I think
> this can fully replace EvDocumentSearch. Text page rendering will be
> managed through the job queue.
> This interface should work both using the same thread than creating a
> separate one for text rendering.

Ah.  That could work.

> >  * selection
> 
> There are two possible approaches here:
> 
> 1 Have ev_page_get_text. We are already rendering a text page every
> time we do a page rendering in GdkOutputDevice, so this should just
> work.
> 2 Stop doing a page rendering every time and do it only when the user
> selected something. (If we arent fast enough this will fail too).
> 
> I think we should go for with 1 at least until we have better
> selection support in poppler. Less changes and less problems.

How do we get the extents of the text?

-Jonathan