Re: First and last page fix



daniel wrote:
Heres the patch to fix the go to first and go to last page funcs in ev-window.c

-dan

Hi Dan,

Sorry, I didn't see your mail when I fixed this last night, but I committed basically the same fix (plus a fix for another of-by-one error). For future reference, we usually use the unified diff format, which you can get by passing -u to cvs diff, like this:

	cvs diff -u

Also, instead of putting a comment in the code describing your change, we use the ChangeLog file in the toplevel directory to log changes to the project.

Thanks,
Kristian



------------------------------------------------------------------------

? evance-first-last-pg.patch
? shell/evince2
Index: shell/ev-window.c
===================================================================
RCS file: /cvs/gnome/evince/shell/ev-window.c,v
retrieving revision 1.88
diff -r1.88 ev-window.c
1488a1489

// First and last page funcs fixed -dwerner 04/05/2005

1494c1495
< 	ev_page_cache_set_current_page (ev_window->priv->page_cache, 1);
---

	ev_page_cache_set_current_page (ev_window->priv->page_cache, 0);

1505c1506
< 	ev_page_cache_set_current_page (ev_window->priv->page_cache, n_pages);
---

	ev_page_cache_set_current_page (ev_window->priv->page_cache, n_pages-1);

1506a1508




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]