Re: Freeze exception request



On Thu, 2016-09-29 at 07:46 -0300, Gustavo Noronha Silva wrote:
The strings are in the gsettings schema, they will only be visible in
dconf-editor:

diff --git a/data/org.gnome.epiphany.host.gschema.xml
b/data/org.gnome.epiphany.host.gschema.xml
new file mode 100644
index 0000000..f70c7b7
--- /dev/null
+++ b/data/org.gnome.epiphany.host.gschema.xml
@@ -0,0 +1,13 @@
+<schemalist>
+  <enum id="org.gnome.Epiphany.host.permissions">
+    <value nick="undecided" value="-1"/>
+    <value nick="deny" value="0"/>
+    <value nick="allow" value="1"/>
+  </enum>
+
+  <schema id="org.gnome.Epiphany.host" gettext-domain="">
+    <key name="notifications-permission"
enum="org.gnome.Epiphany.host.permissions">
+      <default>"undecided"</default>
+    </key>
+  </schema>
+</schemalist>

Gustavo, where are the descriptions of the new settings? :-)

So you have inadventantly not broken string freeze. This patch doesn't
require approval for gnome-3-22, then. But please, add descriptions for
the settings on master.

Michael


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]