Re: Very small patches for review (correct format, and one extra)

[Peter Harvey <peter a harvey gmail com>]

Hi Lee,

Hehe, yeah, oops. I'm technically on holidays, so... :)

I've attached the correct one. Note that this is a pre-cursor patch - I
have another large patch in the works that requires this patch to be in.
I'm just trying to break it up a little.

Regards,
Peter.

On Thu, 2006-01-05 at 22:49 -0500, Lee Revell wrote:
> On Fri, 2006-01-06 at 13:58 +1100, Peter Harvey wrote:
> > ephy-node:
> >   Skip writing out a string property if it is NULL (fixes segfault).
> 
> This one is empty.
> 
> Lee
> 

Index: lib/ephy-node.c
===================================================================
RCS file: /cvs/gnome/epiphany/lib/ephy-node.c,v
retrieving revision 1.41
diff -u -r1.41 ephy-node.c
--- lib/ephy-node.c	10 Jul 2005 20:57:13 -0000	1.41
+++ lib/ephy-node.c	6 Jan 2006 03:00:38 -0000
@@ -724,6 +724,8 @@
 		value = g_ptr_array_index (node->properties, i);
 
 		if (value == NULL) continue;
+		if (G_VALUE_TYPE (value) == G_TYPE_STRING &&
+		    g_value_get_string (value) == NULL) continue;
 
 		ret = xmlTextWriterStartElement (writer, (const xmlChar *)"property");
 		if (ret < 0) break;