[Epiphany] Bug in ephy_embed_utils_save



Hi,

If ephy_embed_utils_save is called with ask_dest == FALSE, the file
already exists and you answer "No" in the confirm-overwrite
dialog, ephy hangs.

The attached patch fixes this.

BTW: In src/window-commands.c (window_cmd_file_save_as) the
EphyEmbedPersist object is g_object_unref'd after the call to
ephy_embed_utils_save, while in src/popup-commands.c (save_property_url)
it's not. Which is correct?

--- epiphany/embed/ephy-embed-utils.c	2003-02-05 21:28:09.000000000 +0100
+++ epiphany-modified/embed/ephy-embed-utils.c	2003-03-10 23:31:57.000000000 +0100
@@ -120,6 +120,7 @@
 		else
 		{
 			g_free (retPath);
+			retPath = NULL;
 			ask_dest = TRUE;
 		}
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]