[Epiphany] Possible Valgrind errors

[Piers Cornwell <piersc cogs susx ac uk>]

Hi,

Ran epiphany though Valgrind earlier (it only works sometimes, not sure
why...) - here's some errors that i got (attached). I presume that most
of these are not actually ephy's fault, but i thought i'd include any
that looked remotely relevent just in case (in fact possibly only the
one on save is ephy's fault?).

Marco: i don't get that error on exit with your patch.

-spark




When adding a new topic:
==878==
==878== Invalid read of size 4
==878==    at 0x80B9EA8: egg_tree_model_filter_row_changed (eggtreemodelfilter.c:1014)
==878==    by 0x4067A3E3: _gtk_marshal_VOID__BOXED_BOXED (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x40B02955: g_closure_invoke (in /usr/lib/libgobject-2.0.so.0.200.1)
==878==    by 0x40B12405: (within /usr/lib/libgobject-2.0.so.0.200.1)
==878==    Address 0x494C0324 is 12 bytes inside a block of size 16 free'd
==878==    at 0x4015D6A4: free (vg_clientfuncs.c:185)
==878==    by 0x40B6D355: g_free (in /usr/lib/libglib-2.0.so.0.200.1)
==878==    by 0x80B920D: egg_tree_model_filter_free_level (eggtreemodelfilter.c:521)
==878==    by 0x80B99E6: egg_tree_model_filter_remove_node (eggtreemodelfilter.c:820)

When saving a file:
==878==
==878== Conditional jump or move depends on uninitialised value(s)
==878==    at 0x808BBC0: impl_save(EphyEmbedPersist*) (mozilla-embed-persist.cpp:187)
==878==    by 0x8083E1E: ephy_embed_persist_save (ephy-embed-persist.c:379)
==878==    by 0x8084BA3: ephy_embed_utils_save (ephy-embed-utils.c:157)
==878==    by 0x8081412: window_cmd_file_save_as (window-commands.c:387)
==878==
==878== Invalid read of size 4
==878==    at 0x809E123: GProgressListener::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned, unsigned) (ProgressListener.cpp:359)
==878==    by 0x43DC8A04: (within /usr/lib/mozilla-snapshot/components/libembedcomponents.so)
==878==    by 0x440A41AB: (within /usr/lib/mozilla-snapshot/components/libnecko.so)
==878==    by 0x43FFAB18: (within /usr/lib/mozilla-snapshot/components/libnecko.so)
==878==    Address 0x4A0EBABC is 112 bytes inside a block of size 148 free'd
==878==    at 0x4015D72B: __builtin_delete (vg_clientfuncs.c:199)
==878==    by 0x4015D749: operator delete(void*) (vg_clientfuncs.c:208)
==878==    by 0x809D63F: GProgressListener::~GProgressListener() (ProgressListener.cpp:65)
==878==    by 0x809CF8F: GProgressListener::Release() (ProgressListener.cpp:46)

Maybe these following ones aren't anything to do with ephy, but just in case:

On address bar:
==878==
==878== Conditional jump or move depends on uninitialised value(s)
==878==    at 0x4064367B: (within /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x40640E3B: gtk_editable_insert_text (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x80B0633: real_entry_set_location (ephy-location-entry.c:353)
==878==    by 0x80A931A: ephy_marshal_VOID__STRING_INT (ephy-marshal.c:409)

==878==
==878== Conditional jump or move depends on uninitialised value(s)
==878==    at 0x4064367B: (within /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x40640E3B: gtk_editable_insert_text (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x80B0633: real_entry_set_location (ephy-location-entry.c:353)
==878==    by 0x80B0C7F: ephy_location_entry_autocompletion_window_url_activated_cb (ephy-location-entry.c:579)

==878==
==878== Conditional jump or move depends on uninitialised value(s)
==878==    at 0x40B8190B: g_utf8_offset_to_pointer (in /usr/lib/libglib-2.0.so.0.200.1)
==878==    by 0x40643B53: (within /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x4067A1C1: _gtk_marshal_VOID__STRING_INT_POINTER (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==878==    by 0x40B02C4E: (within /usr/lib/libgobject-2.0.so.0.200.1)

On new tab:
==940==
==940== Conditional jump or move depends on uninitialised value(s)
==940==    at 0x4064367B: (within /usr/lib/libgtk-x11-2.0.so.0.200.1)
==940==    by 0x40640E3B: gtk_editable_insert_text (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==940==    by 0x80B0633: real_entry_set_location (ephy-location-entry.c:353)
==940==    by 0x8073FF3: ephy_shell_new_tab (ephy-shell.c:415)

When clicking "Set to Blank Page" in prefs (homepage):
==940==
==940== Conditional jump or move depends on uninitialised value(s)
==940==    at 0x4064367B: (within /usr/lib/libgtk-x11-2.0.so.0.200.1)
==940==    by 0x40640E3B: gtk_editable_insert_text (in /usr/lib/libgtk-x11-2.0.so.0.200.1)
==940==    by 0x807D8F3: set_homepage_entry (prefs-dialog.c:1018)
==940==    by 0x40B127DB: g_cclosure_marshal_VOID__VOID (in /usr/lib/libgobject-2.0.so.0.200.1)