Re: [Epiphany] Gtk Certificate Dialogs

[Marco Pesenti Gritti <marco gnome org>]

On Thu, 2003-08-28 at 20:14, Crispin Flowerday wrote:
> Hi,
> 
> Finally I have tidied up the gtk versions of the certificate dialogs
> that I have been working on the last week. The idea is that they should
> be able to work in both galeon and epiphany with as few changes as
> possible.
> 
> You can see screenshots and the main source at:
> 
> http://patches.theflowerdays.com/cert/
> 
> Any comments are appreciated, especially HIG problems, bad wording,
> reasons why it wouldn't be acceptable to epiphany in its current state
> etc.
> 
> (Galeon is mentioned once in one of the dialogs, but I may change that
> to "Your web browser" instead.

Hey,

from a very fast look the code looks good. Nitpick of the day,
I'd use /* */ consistently instead of // though.
I dont think we would want the ESC key thing in epiphany though, at least until
it's decided that esc should dismiss gnome dialogs.

Dave can you take a look to the dialogs ?

Marco