Re: PATCH: builddir != srcdir compile fixes
- From: Federico Mena Quintero <federico ximian com>
- To: Jason Leach <jasonleach usa net>
- Cc: Jens Finke <jens gnome org>, eog-list gnome org
- Subject: Re: PATCH: builddir != srcdir compile fixes
- Date: Wed, 28 Mar 2001 22:52:31 -0600
Jason Leach <jasonleach usa net> writes:
> Small patch for EOG to fix building when objdir != srcdir, the case
> for my build environment with it's many scripts.
>
> The problem is that Eog.h is generated from the Eog.idl and ends up in
> $(builddir)/libeog, not in $(srcdir)/libeog. A few places need to
> #include <Eog.h>, but the Makefile.am for those places don't tell it
> to -I the $(builddir)/libeog.
It would be better if the files that used such headers did
#include "libeog/blah.h"
and just have -I$(top_srcdir) -I$(top_builddir) instead of assuming
that every single path in existence is present in the compiler flags.
> The patch is against HEAD, tell me if it's OK to commit.
Please make those changes to the relevant files and commit it.
> Also, EOG doesn't appear to have a Bugzilla package made for it on
> bugzilla.gnome.org, would you like me to create one for you? If so,
> which of you has already made a bugzilla account there, so I can set
> you as the component owner?
I would like to be the component owner, thank you. We should tell
Bugzilla to CC eog-list as well.
Thanks, Jason!
Federico
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]