Re: [Ekiga-list] Ekiga && V4L && FreeBSD

[Damien Sandras <dsandras seconix com>]

Le mercredi 19 mars 2008 à 14:11 +0100, Matthias Apitz a écrit :
> El día Wednesday, March 19, 2008 a las 01:51:45PM +0100, Damien Sandras escribió:
> 
> > 
> > Le mercredi 19 mars 2008 à 13:09 +0100, Matthias Apitz a écrit :
> > > El día Wednesday, March 19, 2008 a las 11:48:00AM +0100, Matthias Apitz escribió:
> > > 
> > > > What is on Linux the major and minor number of the device file for the
> > > > cam? on FreeBSD it is:
> > > > 
> > > > $ ls -l /dev/video0
> > > > crw-rw-rw-  1 root  operator    0, 146 19 mar 09:02 /dev/video0
> > > > 
> > > > it seems that the algorithm in vidinput_v4l.cxx depends on minor
> > > > numbers below 63 in void  V4LNames::ReadDeviceDirectory()
> > > > 
> > > > see also the CVS comment:
> > > > 
> > > >  * Revision 1.3  2003/11/25 22:55:13  dsandras
> > > >  * Added fallback using major and minor numbers for detection of devices
> > > >  * when /proc/video doesn't exist
> > > >  (some 2.4 kernels and all 2.6 kernels).
> > > 
> > > Yes, it is an issue of major/minor numbers which are diffrent in Linux
> > > and FreeBSD vor the cam; with this small change:
> > > 
> > > # pwd
> > > /usr/ports/devel/pwlib/work/pwlib_Phobos_release2/plugins/vidinput_v4l
> > > # diff vidinput_v4l.cxx*
> > > 462,464c462
> > > <           // static const int deviceNumbers[] = { 81 };
> > > <           // for FreeBSD's pwc driver the major number is 0 and minor is 146
> > > <           static const int deviceNumbers[] = { 0 };
> > > ---
> > > >           static const int deviceNumbers[] = { 81 };
> > > 468,469c466
> > > <               // if (num <= 63 && num >= 0) {
> > > <               if (num <= 146 && num >= 146) {
> > > ---
> > > >               if (num <= 63 && num >= 0) {
> > > 
> > > the driver attaches without any problem; to whom to talk about get this
> > > integrated into pwlib?
> > 
> > Mail me the patch, I will commit it to trunk.
> > Isn't the patch also needed for vidinput_v4l2 ?
> 
> Yes, the same hardcode major/minor number is in vidinput_names.cxx for
> vidinput_v4l2;
> 
> concerning a patch, I can't provide a common solution which works on
> Linux and FreeBSD because I'm not a C++ programmer; I only could hack
> the code as shown above so that it will work in FreeBSD; maybe Steve
> should just put this into a patch file for the /usr/ports/devel/pwlib in
> the FreeBSD ports tree; Steve?
> 

And contribute it back to us, otherwise we can not commit it...
-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   NOVACOM         : http://www.novacom.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net