Re: [Ekiga-devel-list] patch for ptlib for V4L2 support in FreeBSD

[Eugen Dedu <Eugen Dedu pu-pm univ-fcomte fr>]

On 27/05/11 20:45, Matthias Apitz wrote:
> El día Friday, May 27, 2011 a las 08:05:51PM +0200, Eugen Dedu escribió:
>
> > > Committed, thanks, see
> > > http://opalvoip.svn.sourceforge.net/viewvc/opalvoip?view=revision&revision=25913
> > > and
> > > http://opalvoip.svn.sourceforge.net/viewvc/opalvoip?view=revision&revision=25914.
> > >
> > >
> > > > +Cc: melifaro ipfw ru (maintainer of /usr/ports/devel/ptlib26)
> > >
> > > Really added the CC.
> >
> > I see in your patch that a mutex has been replaced with flush.  Is that
> > correct for all architectures?
>
> Are you sure about the replacement? These lines get added:
>
> +  PWaitAndSignal m(mutex);
> +  inputDeviceNames.RemoveAll (); // flush the previous run
> +#if defined(P_FREEBSD)
>
> and later on removed
> ...
>     }
> -  PWaitAndSignal m(mutex);
> -  inputDeviceNames.RemoveAll (); // flush the previous run
>
> i.e. there is no replacement. The patch should just insert the FreeBSD
> code below
>
>    PTRACE(1,"Detecting V4L2 devices");
>    PWaitAndSignal m(mutex);
>    inputDeviceNames.RemoveAll (); // flush the previous run
> #if defined(P_FREEBSD)
>    ...
>
> I'm wrong? I checked the result too, and it looks fine for me.

Sorry, it was only a movement of code...  It is ok.

--
Eugen