Re: [Ekiga-devel-list] Warning for revision.h

[Eugen Dedu <Eugen Dedu pu-pm univ-fcomte fr>]

Michael Rickmann wrote:
> Am Donnerstag, den 30.04.2009, 16:41 +0200 schrieb Eugen Dedu:
> > Hi,
> >
> > After the update of revision.h I receive the following wraning:
> > Making install in src
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > make[2]: Entering directory 
> > `/home/dedu/softs/ekiga/toto/ekiga-3.2.0+git20090430.81e65f/src'
> > /usr/bin/make  install-am
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > make[3]: Entering directory 
> > `/home/dedu/softs/ekiga/toto/ekiga-3.2.0+git20090430.81e65f/src'
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > /bin/sh: line 0: cd: ../.git: No such file or directory
> > fatal: Not a git repository (or any of the parent directories): .git
> > make[4]: Entering directory 
> > `/home/dedu/softs/ekiga/toto/ekiga-3.2.0+git20090430.81e65f/src'
> >
> > This is because cd ../.git is always executed in src/Makefile.am:
> > GIT_REVISION=\"$(shell (cd ../.git; git describe ))\"
> > CACHED_REVISION=$(shell cat revision.h 2>/dev/null | cut -c24-)
> >
> > There should be an if before the "cd"...
> Sorry, I did not recognize that the $(shell ) constructs are executed
> each time a Makefile is read. Could you test attached patch? It seems
> allright for me.

It's ok.  Checked-in master+branch.  Thanks!

--
Eugen