Re: [Ekiga-devel-list] Testing of bug 558587

[Damien Sandras <dsandras seconix com>]

Le jeudi 13 novembre 2008 à 22:16 +0000, Peter Robinson a écrit :
> >> >> I'm trying to get a decent backtrace with all the debuginfo stuff
> >> >> installed. From my testing it seems that it happens even when a call
> >> >> is rejected. It seems to affect what will become Fedora 10 quite badly
> >> >> for some reason. I'm not sure whether we can make the cutoff for
> >> >> packages with a fix which is Friday, but would love to get a zero day
> >> >> update available.
> >> >
> >> > Are you sure it affects so many people ?
> >> > I don't even see in which thread it crashes :(
> >>
> >> I setup a very simple asterisk box today with 2 extensions and
> >> connected two ekiga endpoints to it. I ran ekiga in a gdb session and
> >> collected a backtrack with a "thread apply all bt" so it should have
> >> caught all needed with luck. Its attached to the bug. gdb complains
> >> about not having some debuginfo packages installed but I think its
> >> essentially listing everything in the gnome stack, I don't think i
> >> have any of the important ones missing. If there is let me know as I
> >> can now recreate this issue on demand.
> >
> > There is something very weird. A few developers and myself can not
> > reproduce it at all...
> >
> > If you look at the crash, you can see this :
> > #0  IA__g_type_check_instance_cast (type_instance=0x2,
> > iface_type=11338368) at gtype.c:3723
> > #1  0x000000000049eec4 in closed_cb (main_window=0x2) at gui/main.cpp:3644
> >
> > closed_cb takes only one argument, which is main_window and which has an invalid value.
> >
> > On my system, closed_cb is defined as this (with 2 arguments):
> > static void
> > closed_cb (NotifyNotification* /*notify*/,
> >           gpointer main_window)
> >
> > My libnotify version is 0.4.4 and you ?
> 
> Same,  with a couple of patches from upstream. The one that looks like
> it might be an issue has the change log entry "Handled extra parameter
> of closed signal
> " Patch can be seen here
> http://cvs.fedoraproject.org/viewvc/rpms/libnotify/F-10/libnotify-closed-reason.patch?view=markup

That explains it.

Changing the API without changing the version number and breaking
compatibility is not a very wise thing to do.

Try changing :
static void
closed_cb (NotifyNotification * /*notify*/,
           gpointer main_window)
in main.cpp into
static void
closed_cb (NotifyNotification * /*notify*/,
           gint /*reason*/,
           gpointer main_window)

It should work.

Good catch btw, but I really think it is not a good idea from Fedora to
do that. They potentially break many programs. And I can not even modify
Ekiga as it is a local Fedora patch, you will have to apply a patch
yourself.
-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   Be IP           : http://www.beip.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net