Re: [Ekiga-devel-list] notify lib includes non top-level header

[Damien Sandras <dsandras seconix com>]

Le mercredi 10 décembre 2008 à 10:20 +0100, Eugen Dedu a écrit :
> Hi,
> 
> It seems ekiga is ahead of time for gtk_single_includes.  I receive the 
> following error:
> 
> make[3]: Entering directory `/home/dedu/softs/ekiga/ekiga/src'
> g++ -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib/gmconf -I../lib/toolbox 
> -I../lib/gui -I../lib/engine/ -I../lib/engine/framework 
> -I../lib/engine/gui/gtk-frontend -I../lib/engine/account/skel 
> -I../lib/engine/addressbook/skel -I../lib/engine/chat/skel 
> -I../lib/engine/presence/skel -I../lib/engine/protocol/skel 
> -I../lib/engine/protocol/sip -I../lib/engine/videooutput/skel 
> -I../lib/engine/videoinput/skel -I../lib/engine/audioinput/skel 
> -I../lib/engine/audiooutput/skel -I../lib/engine/hal/skel 
> -I../lib/engine/framework -I../lib/engine/gui/gtk-core 
> -I../lib/engine/components/opal -I../src -I../src/dbus-helper/ 
> -I../src/gui/ -I..  -DSCHEMA_AGE=62 -I../lib/engine/videooutput/common 
> -I../lib/engine/videooutput/x    -D_REENTRANT -I/usr/include/gtk-2.0 
> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
> -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 
> -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 
>    -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED 
> -DGTK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES 
> -DGTK_DISABLE_SINGLE_INCLUDES -pthread -I/usr/include/glib-2.0 
> -I/usr/lib/glib-2.0/include   -DG_DISABLE_SINGLE_INCLUDES 
> -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include 
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -DPTRACING=1 
> -D_REENTRANT -D_GNU_SOURCE=1 -fno-exceptions -I/usr/include/opal 
> -I/usr/include/SDL   -DPTRACING=1 -D_REENTRANT -D_GNU_SOURCE=1 
> -fno-exceptions -I/usr/include/SDL   -I/usr/include/sigc++-2.0 
> -I/usr/lib/sigc++-2.0/include   -I/usr/include/libxml2   -D_REENTRANT 
> -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 
> -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 
> -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include 
> -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 
> -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 
> -I/usr/include/pixman-1   -Wall -g -O2 -Wall -Wextra -Winit-self 
> -Wswitch-default -Wswitch-enum -Wstrict-aliasing=2 -Wfloat-equal 
> -Wshadow -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o `test -f 
> 'gui/main.cpp' || echo './'`gui/main.cpp
> In file included from /usr/include/libnotify/notification.h:28,
>                   from /usr/include/libnotify/notify.h:27,
>                   from gui/main.cpp:85:
> /usr/include/gtk-2.0/gtk/gtkversion.h:28:2: error: #error "Only 
> <gtk/gtk.h> can be included directly."
> 
> The error is that /usr/include/libnotify/notification.h:28 includes a 
> non top-level header :o(
> 
> I sent a bug report 
> (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508329), but I don't 
> know when it will be fixed.  Also, it is fixed in the next version of 
> libnotify (0.4.5), not yet packages in debian.
> 
> Until then, the best solution I see is to remove 
> -DGTK_DISABLE_SINGLE_INCLUDES for src/gui/main.cpp


I have removed those flags from the default compilation, they are only
present for debugging purposes.

I made the following changes :
1) I renamed --enable-debug into --enable-opal-debug to link against the
debug versions of the libs
2) I added --enable-gtk-debug that adds the above defines together with
the DISABLE_DEPRECATED* stuff

It will be committed in a few seconds.
-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   Be IP           : http://www.beip.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net