Re: [Ekiga-devel-list] Some points on the EKIGA/OPAL video plugin

[Damien Sandras <dsandras seconix com>]

Hi,

Thanks for the patches.

Le lundi 30 octobre 2006 à 08:00 +0100, Matthias Schneider a écrit :
> Hi,
> Ok, I located the problem in manager.cpp lines 286- :
> 
>       if (sip_list [i].GetPayloadType () == h323_list [j].GetPayloadType ()
>           && sip_list [i].GetBandwidth () == h323_list [j].GetBandwidth ()) {
> 
>         full_list += sip_list [i];
>         full_list += h323_list [j];
>       }
> So only one codec description is inserted in the table if PTs and Bandwidth settings match between
> h323 and sip instance. However if the codec is registered with dynamic payload, it gets assigned
> different payload type values (can be checked with opalcodecinfo, in this example I only modfified
> the RTPExplicit flag to RTPDynamic in the h261 plugin):
>               H.261-CIF  video, bandwidth=621700, RTP=114, h323=yes, sip=no
>              H.261-QCIF  video, bandwidth=621700, RTP=115, h323=yes, sip=no
>                   H.261  video, bandwidth=621700, RTP=96, h323=no, sip=yes
> So how can we correct this problem? Do the comparison on another basis than the PT?
> 

I don't know. Craig?

The problem is that this code is used to prevent having several times
the same codec with different names in teh codecs list.
-- 
Damien Sandras

Ekiga Softphone : http://www.ekiga.org
NOVACOM                    : http://www.novacom.be
FOSDEM                      : http://www.fosdem.org
SIP Phone               : sip:dsandras ekiga net