Re: [RFC] MP4 tag handler using taglib C++ API



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi David,

On 09/04/14 23:52, David King wrote:
Hi Santtu

I just tidied this up (my C++ is rather rusty, so comments
welcome)

I forgot to address this one; but not much to say, as the code is
pretty much straight C, just using some C++ methods.

One note, however, is that the extern "C" declarations are unnecessary
in the source file, it is enough that they are present during function
declaration (which is done in mp4_tag.h, which has the G_BEGIN_DECLS,
that extends to extern "C"). So that can be removed (and the closing
curly brace too, of course).

- -- 
Santtu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlNGR04ACgkQX9Rc0+po4p2qpQCghv6LguJe+xzqIma7KO9gZJxx
DqoAni6p7YtHgTF9dS5+yoFezPhEZRT0
=ZPQF
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]