Hi Santtu On 2014-04-04 08:06, Santtu Lakkala <inz inz fi> wrote:
Roman numeral detection code used complicated process of check, parse, build, compare to detect if a string was a valid roman numeral. Reimplemented as a single step, that only checks for the validity (and well-formedness) of the string, without computing its value. It uses the same modern Roman numeral notation, including subtractive notation.
Thanks for the patch! I modified it, adding back the toggle button check and doing some light reformatting, and pushed it to master:
https://git.gnome.org/browse/easytag/commit/?id=a6b44d7abbf150235bcdc3233fe1161c3191c0b5 It is a great simplification over the old Roman numeral detection. -- http://amigadave.com/
Attachment:
signature.asc
Description: Digital signature