Re: [Easytag-mailing] [PATCH] generate cddb query from song lengths
- From: Jérôme Couderc <j couderc ifrance com>
- To: justus schwartz <justus gmx li>
- Cc: Daniel Drake <dan reactivated net>, easytag-mailing lists sourceforge net
- Subject: Re: [Easytag-mailing] [PATCH] generate cddb query from song lengths
- Date: Mon Sep 20 16:28:01 2004
Hi Justus,
Thanks a lot for your patch whitch was included in my current sources
and available on the next release.
Regards,
Jerome
justus schwartz wrote:
hi!
Daniel Drake <dan reactivated net> writes:
If we can get the code simple/clean enough then it should be up for consideration.
ok, i've addressed the problems you mentioned below, i just copied most of the
code from other functions, therefore missed the deleting stuff. i suppose
gettext is for i18n? i'm not so sure about the position of the button and the
text on it at all, therefore i haven't changed that yet.
i also found a minor bug in line 2159 of cddb.c
instead of
file_selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
file_selectedcount = gtk_tree_selection_count_selected_rows(selection);
it should be
file_selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
file_selectedcount = gtk_tree_selection_count_selected_rows(file_selection);
else one can crash easytag by selecting all files in the cddb view and
unselecting all files in the browser view and then clicking apply in the cddb
window.
has anybody implemented (or is implementing) the parsing of cddb records of
albums with various artists. quote from freedb.org faq:
6. When submitting a sampler or compilation, you should include the
track-artist in the track-name, using the syntax "artist / track-title" and
set the CD-artist to "Various"
it would be nice to tag mp3s from such records with easytag.
This is also a good idea, fancy writing a patch? :)
i'll think about it, but unfortunately people submitting cddb data often don't
stick to the "rules" :(, therefore i'm not sure, if it is worth implementing
this. (retagged today a lot of my mp3s, and saw a lot of strange cddb records)
ciao
-justus
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <j couderc ifrance com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]