Re: dogtail [PATCH] Add support for only searching among 'showing' nodes.

[Vitezslav Humpa <vhumpa redhat com>]

Heya,

----- Original Message -----
> Vitezslav Humpa:
> > Hi anonym!
> >
> > You've caught me just before departing on my this time mainly offline
> > weekend :)
>
> New week now! :)

Oh no, the weekend's over! :)

> > We will be moving the 'official' repo of dogtail from fedoraproject
> > to gitlab.com soon, so merge requests there will be the best way of
> > contribution. It's already setup and synced, with CI for patches So
> > meanwhile I have submitted your patch there in 'showingonly' branch
> > for the unittests to crunch.
>
> I see failures in
>
>   https://gitlab.com/dogtail/dogtail/builds/1051864
>
> for example,
>
>   ======================================================================
>   ERROR: test_action_on_insensitive (test_procedural.TestActions)
>   ----------------------------------------------------------------------
>   Traceback (most recent call last):
>     File
> "/home/test/builds/b11296d9/0/dogtail/dogtail/tests/test_procedural.py",
> line 21, in setUp
>       self.pid = run('gtk3-demo')
>     File
> "/home/test/builds/b11296d9/0/dogtail/dogtail/dogtail/procedural.py",
> line 411, in run
>       pid = utilsRun(application + ' ' + arguments, appName=appName)
>     File
> "/home/test/builds/b11296d9/0/dogtail/dogtail/dogtail/utils.py", line
> 111, in run
>       if child.name == appName:
>   Error: atspi_error: The application no longer exists (0)
>
> So, as I understand it, `self.pid = run('gtk3-demo')` just fails, and
> that is in fact the first thing that is run in this test so there is no
> prior state that interferes. AFAICT my changes do not touch the code
> path taken here so I do not really see how it can be related. Any way,
> let's not "blame the tests" just yet. :) Well, since the move to Gitlab
> was recent, perhaps the CI setup isn't 100% reliable yet?

Indeed blame the tests :) What happened is that prior to the commit was pushed
the gitlab runner instance got accidentally deleted. Yeah... So I had to re-setup everything
yesterday (also made steps to prevent such deletions again and set up backups) and
the 'builds' from yesterday are just a first iteration of trying out the 'new' setup.
The 'sudo' wasn't setup properly in this case.

So no worries, I am working on redoing and rerunning the unittests in 'CI',
your code is surely not to blame :) (the guy who thought 'Terminate' instance
means just a shutdown is)

> Clearly I should have tried running the test suite myself before
> submitting this pull request. I do not run GNOME myself, so before I
> potentially waste my time, is there anything preventing me from just
> setting up a chroot with the deps and run the tests in there?

The whole point of running the unittest in CI on commits is to save us time
maintaining code for two python versions and too keep git master (and human :))
sanity. So no worries, you don't have to run them. If you want to do so though,
you need to have the deps (+ gtk3-demo for tests), be in a X session with a11y
all enabled and run them with nosetests.

Thanks!
Vita

> Cheers!