Re: maybe a bug



On Thu, 2019-05-09 at 22:28 +0430, Vahid Bashiri via dia-list wrote:
consider following simple case 

where an object connected to a zigzagline at one end and the other end is free. The zigzagline has two handles at each end, you can connect to, let say handle[0] and handle[1].
If handle[1] connected to object and handle[0] is free, if you select the obj and press delete, the for loop starts with handle[0] and because 
handle[0]->connected_to is NULL (its not connected) it will "break" without checking handle[1]Then program continues with 
deleting obj and after deleting obj you'll have a zigzagline with  handle[1]->connected_to pointing to an object that doesn't exist  anymore.
The solution is continue with other handles of an object and check all of them which means a continue should be in place of break . 

See said I'd probably misunderstood you!

I'm *fairly* certain this shouldn't be an issue but I've fixed in on master anyway, thanks for the contribution!

_______________________________________________
dia-list mailing list
dia-list gnome org

https://eur02.safelinks.protection.outlook.com/?url="">

FAQ at 
https://eur02.safelinks.protection.outlook.com/?url="">

Main page at 
https://eur02.safelinks.protection.outlook.com/?url="">


-- 
Zander Brown <zbrown gnome org>
GNOME Design Tooling (Icon Preview)
Dia Diagram Editor

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]