Re: add line width to uml small package



Thanks for the review.

Strange ... the ...->line_with = attributes_get_default_linewith() are there, at least in my sources ... The patch includes:

The patch fragment for note:
@@ -305,13 +307,14 @@

   elem->corner = *startpoint;

+  note->line_width = attributes_get_default_linewidth();

The patch fragment for large_packge:
@@ -347,6 +354,7 @@
   elem->width = 4.0;
   elem->height = 4.0;

+  pkg->line_width = attributes_get_default_linewidth()

The patch fragment for class:
@@ -1785,6 +1787,7 @@

   umlclass->stereotype_string = NULL;

+  umlclass->line_width = attributes_get_default_linewidth();

those are all in the <whatever>_create method. Is something I am missing?

I'll test removing ~/.dia/defaults.dia. Thanks a lot.

Hans Breuer wrote:
At 26.09.2008 03:45, Pablo Gra\~na wrote:
Here is a new patch with more UML objects with the configurable line width:

note
Looks like there is missing a
  note->line_width = attributes_get_default_linewidth();
in note_create()

large_package
class
same here

object
class.h
class_dialog
usecase
actor
small_package

I'd like to know if this is the correct way. I'll continue with the others and send another patch.

otherwise it looks fine. For testing property additions I'm ususally creating a diagram with all objects to be modified. It needs to load correctly - without complains - even when ~/.dia/defaults.dia is deleted.

Thanks,
    Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert
_______________________________________________
dia-list mailing list
dia-list gnome org
http://mail.gnome.org/mailman/listinfo/dia-list
FAQ at http://live.gnome.org/Dia/Faq
Main page at http://live.gnome.org/Dia


--



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]