Re: segfault when creating new objects



At 19.12.2008 20:46, Sameer Sahasrabuddhe wrote:
Hello,

Attached a patch that ensures that a new object is really created when
using CreateObjectTool.
Sorry, I don't see how adding g_return_if_fail() should ensure anything.
It is just a debug helper and can get compiled out.
Also your patch would partially revert revision 3876 (for the above mentioned case):

2008-01-10  Hans Breuer  <hans breuer org>

 * app/create_object.c(create_object_button_release) : don't crash on
   tool->obj being NULL, just do nothing than.

I actually encountered this because of another
problem with the DATADIR setting. I suppose the CreateObjectTool
rarely fails in normal environments.

It rarely does but still should not crash.

        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]