Re: [gnome-desktop-testing] [branch work] could it be merged into mainstream?

[Nagappan Alagappan <nagappan gmail com>]

Hello Tac,

Over all the changes look good. Thanks for the contribution.

I have few comments:

* In utils.py probably you can import the time module and then use time.function (Just my personal preference :)
* In utils.py instead of getMeAName you can use a meaningful name like gettempfilename
* In gedit_edit_test.py typo, I think :) instead of 'hello boy and girls!' you can have it as 'hello boys and girls!'

Thanks
Nagappan

On Mon, May 18, 2009 at 1:53 AM, tac <Junyuan Tan sun com> wrote:

Hi list,
  Earlier, I had applied a patch to show my idea for gedittestcase on gdt project.
  Following Javier's suggestion, I registered a branch on lp and continued doing there.
  And now I want to ask if someone could take a few minutes to review it, I'd like to know
that it is ready to merge this into mainstream.

Thanks,

In the branch:

+ adding some functions in desktoptesting module, which I believe useful
+ add more functions to gnome.py to enhance gedit testing
+ give two test case for examining the new test feature.

To test it,

you can check it out with

bzr branch lp:~junyuan-tan/gnome-desktop-testing/testcase <dir>
cd dir
bin/desktoptesting

--
----------------------------------------------
tac @ Sun China
    junyuan tan sun com
extn: +86-10-62673641 intn: 51641
----------------------------------------------

_______________________________________________
http://live.gnome.org/DesktopTesting
desktop-testing-list mailing list
desktop-testing-list gnome org
http://mail.gnome.org/mailman/listinfo/desktop-testing-list

-- 
Linux Desktop (GUI Application) Testing Project - http://ldtp.freedesktop.org
http://nagappanal.blogspot.com