Re: gnome github


On Sat, Dec 26, 2015 at 04:39:23PM +0000, Patrick Welche wrote:
There is a rather good pull request waiting for me at

I was under the impression though that github is one way - if I apply
it on github, will it make its way back to

No, it won't make its way back to

The other issue is just how deeply we frown on merges? (Given the patch
set, I would just apply it...)

Some people do frown on merge commits, but there is nothing wrong with
rebasing a feature branch and merging it. In any case, it is upto to
the maintainers of the module whether to use merge commits or not, and
since you are in charge of dasher, you should feel empowered to decide
how you go about merging the patches.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]