Re: Fix check for systemd in modules that talk to logind



Hello all,

Bastien Nocera [2013-03-21 11:07 +0100]:
On Thu, 2013-03-21 at 10:36 +0100, Olav Vitters wrote:
On Thu, Mar 21, 2013 at 07:03:24AM +0100, Martin Pitt wrote:
This affects the following GNOME modules:

  gnome-shell gnome-session gnome-screensaver gdm gnome-system-monitor

and the following software around/beneath GNOME:

  pulseaudio accountsservice upower udisks dbus

I will file bugs with patches for those in the next days. IMHO they
are unintrusive enough to be included into GNOME 3.8.1, but if you
want to wait until 3.9.x we can just distro-patch packages until then.

As upstream agrees with you, let's include this in either 3.8.0 or
3.8.1.

-session and -shell are trivial, so if you think they are appropriate
for the freeze, sure. gdm is a rather big one, I guess that has time
for .1.

I fixed upower and udisks this morning, and sent a patch for dbus
(https://bugs.freedesktop.org/show_bug.cgi?id=62585). I'll get to the
other stuff soon, I'm keeping track in [1].

Martin, can you file bugs about those?

Sure, as I said in my original mail.

g-session: https://bugzilla.gnome.org/show_bug.cgi?id=696262
g-shell: https://bugzilla.gnome.org/show_bug.cgi?id=696252 (already A-C-freeze)
g-screensaver: https://bugzilla.gnome.org/show_bug.cgi?id=696264
gdm: https://bugzilla.gnome.org/show_bug.cgi?id=696266

I didn't prepare one for system-monitor yet as this needs some more
tought (either checking for both sd_booted() and logind, or making it
resistant to failures of sd_pid_get_unit()).

(as far as I can see, you'll have to deal with gnome-screensaver
yourself though, it's abandonware).

Ah, mind if I just push that one then? (It's trivial)

Martin

[1] http://people.canonical.com/~pitti/tmp/cgroup-sd_booted.txt
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]