Re: Reviewed-By: and pastebins

[Colin Walters <walters verbum org>]

On Thu, 2012-05-03 at 13:00 -0400, Ray Strode wrote:

> I don't think the person who reviewed a patch is always critical
> information, though.  Certainly, drive-by pastebin patches should be
> trivial and obvious.  If the proposed changes aren't trivial and
> obvious, then they should go to bugzilla first so there is a paper
> trail leading back to the discussion.

Right, I do the copy-irc-to-bug approach sometimes for that.

> Basically, adding the reviewer's name doesn't hurt anything, but my
> opinion is it doesn't necessarily help either.  What does help is
> knowing that the patch was sanity checked at all (like you said), and
> not committed blindly, and at that point adding the person who did the
> sanity checking doesn't seem like a bad idea.

So I take this as..."not opposed, but do remember to use bugzilla for
nontrivial patches".