Re: Use of maintainer mode in GNOME modules

[Vincent Untz <vuntz gnome org>]

Le vendredi 09 septembre 2011, à 13:49 +0100, Javier Jardón a écrit :
> On 9 September 2011 13:24, Vincent Untz <vuntz gnome org> wrote:
> > Le vendredi 09 septembre 2011, à 13:09 +0100, Javier Jardón a écrit :
> >> Hi all,
> >>
> >> As you can read in the Ryan blog post [1], the use of the
> >> AM_MAINTAINER_MODE macro is only correct when used in this way:
> >>
> >> AM_MAINTAINER_MODE([enable])
> >>
> >> As ryan said in the blog post, fredp made a report page for packages
> >> using AM_MAINTAINER_MODE.
> >>
> >> green  -> no “AM_MAINTAINER_MODE” at all (good)
> >> yellow -> “AM_MAINTAINER_MODE([enable])”  (fine)
> >> orange -> means that your package is currently broken and needs to be fixed.
> >>
> >> So if Its not already fixed in your module, we are going to proced to
> >> fix all the GNOME modules that appear
> >> in "orange" and convert it to "yellow", ie
> >>
> >> AM_MAINTAINER_MODE -> AM_MAINTAINER_MODE([enable])
> >>
> >> Thanks for you collaboration.
> >
> > I'd prefer to get https://bugzilla.gnome.org/show_bug.cgi?id=658608
> > fixed, instead of adding back AM_MAINTAINER_MODE in my modules.
> 
> We are not going to modify the modules that are not using
> AM_MAINTAINER_MODE at all (green).
> We are only going to change the modules that are using
> AM_MAINTAINER_MODE (orange) to
> AM_MAINTAINER_MODE([enable])
> 
> Also, that bug is unrelated with the use of AM_MAINTAINER_MODE

Sorry, you're wrong :-)

gnome-session is orange in the report and doesn't use
AM_MAINTAINER_MODE. And that's because it uses the
GNOME_MAINTAINER_MODE_DEFINES macro, which has:
 AC_REQUIRE([AM_MAINTAINER_MODE])

This is what Ryan wanted to fix in the bug above :-)

Vincent

-- 
Les gens heureux ne sont pas pressés.