Re: [gnome-session] rename gnome-session-save to gnome-session-quit
- From: Bastien Nocera <hadess hadess net>
- To: Vincent Untz <vuntz gnome org>
- Cc: William Jon McCann <mccann src gnome org>, desktop-devel-list gnome org
- Subject: Re: [gnome-session] rename gnome-session-save to gnome-session-quit
- Date: Mon, 28 Feb 2011 12:58:54 +0000
On Mon, 2011-02-28 at 13:56 +0100, Vincent Untz wrote:
> Hi,
>
> (I don't want to pick on Jon here; that's just the latest commit like
> this one)
>
> I would appreciate if patches could get posted on bugzilla for review,
> instead of being committed directly without asking maintainers. I know
> I'm not the fastest reviewer out there, but as I've told several times
> before, if you think the patch is important and doesn't get a review
> before the next release, then it's welcome to push the patch.
>
> In this case, the patch is mostly good, but the man page is wrong
> (--logout is the default behavior, but it's not mentioned and it's
> unclear what happens by default; --no-prompt doesn't do anything with
> --power-off).
The equivalent patch made to gnome-settings-daemon/plugins/media-keys
would also be appreciated.
Cheers
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]