Re: GtkNotebook scrolling usability

[Alberto Ruiz <aruiz gnome org>]

2010/3/11 Johannes Schmid <jhs jsschmid de>:
> Hi!
>
> Am Donnerstag, den 11.03.2010, 14:20 +0000 schrieb Alberto Ruiz:
>> Now that I think about it, I think the notebook needs a review from a
>> wider perspective.
>> We are trying to make this class one-size-fits-all-cases.
>>
>> We already discussed about simplifying this widget a bit (we already
>> deprecated the tab-pack child prop for example),
>> other things should be simplified as well (I just filed bug #612567
>> about properties that should be).
>>
>> I think that preference and MDI tabs are quite different, I think we
>> should have an DocumentsNotebook and PreferencesNotebook classes using
>> GtkNotebook as a base class, both classes can then provide sane
>> defaults and additional properties for both use cases (like close
>> button on MDI tabs which makes no sense on preference tabs)
>
> I am not sure if we need the two classes but I would love to see someone
> step up and clean the GtkNotebook code in general for 3.0. Having worked
> on a couple of bugs/features for GtkNotebook I must say that it has
> probably the most crappy code of all Gtk+ widgets.
> That doesn't blame any of the authors but this code has grown
> incrementally and became worse as nobody had a clean concept. And most
> of the code was already in Gtk+ 1.2.

This is part of the story of my proposal, it's not better only from an
API usability point of view, but it also prevents from having a single
class where all the crack gets added, making the whole situation a
little more sustainable long term wise.

> Regards,
> Johannes
>



-- 
Un saludo,
Alberto Ruiz