Re: Would this be a break?

[Lennart Poettering <mztabzr 0pointer de>]

On Sat, 12.09.09 17:01, Nirbheek Chauhan (nirbheek gentoo org) wrote:

> 
> On Sat, Sep 12, 2009 at 4:45 PM, Philippe Rouquier
> <rouquier p wanadoo fr> wrote:
> > I just got a patch today that add a minor feature to brasero (see
> > https://bugzilla.gnome.org/show_bug.cgi?id=594954). Once applied the patch
> > allow brasero to emit a sound. the code is quite small but I was wondering
> > if it would be considered as a break for any of the freezes.
> 
> This won't break UI Freeze + String Freeze if there's no option in the
> menu(s) to disable it (is it supposed to be there? Or is it supposed
> to be globally controlled? Lennart should know this.)

With very few exceptions event sounds should be controlled globally in
the sound capplet. There you can globally disable/enable event sounds or
choose a different sound theme that disables or enables specific
sounds.

I think it would be bad UI if all apps had seperate checkboxes for
enabling event sounds.

(BTW, the very few exceptions I mentioned above are probably IM and
email notifications. Many people receive such a high volume of
emails/IMs that it is probably a good idea to allow them to disable
these sounds in the application)

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4