Re: git commit messages



On Wed, Apr 22, 2009 at 4:09 PM, Christophe Fergeau <teuf gnome org> wrote:
> Hi Vincent,
>
> 2009/4/22 Vincent Untz <vuntz gnome org>
>>
>> - When committing code on behalf of others use the --author option, e.g.
>>    git commit -a --author "Joe Coder <joe coder org>" and --signoff.
>>
>> ========================================================
>>
>>
>> Opinions?
>
> Not sure about the --signoff part. The committer email/name is already
> silently added to the commit by git even when using --author. Moreover, When
> reading the "12) Sign your work " section of SubmittingPatches from the
> linux kernel source (
> http://lxr.linux.no/linux/Documentation/SubmttingPatches ), it seems to me
> that using SignedOffBy is useless if the initial author of the patch didn't
> use it :
>
> "The sign-off is a simple line at the end of the explanation for the patch,
> which certifies that you wrote it or otherwise have the right to pass it on
> as a open-source patch." (snipped a lot of explanations after this sentence)

There was a recent discussion on this,
http://mail.gnome.org/archives/gnome-infrastructure/2009-April/msg00011.html

Simos


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]