Re: gnome-session string freeze breakage

[Carlos Garnacho <carlosg gnome org>]

Fuck! I'm dumb, my apologies, I somehow thought that it was already
branched and didn't check it out before the commit

	Sorry


On Fri, 2005-05-06 at 11:28 +0100, Mark McLoughlin wrote:
> Hi,
> 	Thanks for that. I've created a gnome-2-10 branch now and reverted
> those changes from the branch.
> 
> 	I did it that way, rather than going back and branching before the
> changes, so as to make sure the gnome-2-10 branch got all the
> translations which have been updated since then.
> 
> Cheers,
> Mark.
> 
> On Fri, 2005-05-06 at 11:43 +0200, Martin Willemoes Hansen wrote:
> > There has been an unannounced string freeze breakage in the string
> > frozen gnome-session for gnome-2-10, it seems that gnome-session has not
> > branched for gnome-2.10 yet.
> > 
> > Two new strings has been added.
> > 
> > These are the messages:
> > 
> > #: ../gnome-session/gnome-session.schemas.in.h:8
> > msgid "Selected option in the log out dialog"
> > 
> > #: ../gnome-session/gnome-session.schemas.in.h:12
> > msgid ""
> > "This is the option that will be selected in the logout dialog, valid values "
> > "are \"logout\" for logging out, \"shutdown\" for halting the system and "
> > "\"restart\" for restarting the system."
> > 
> >         
> > The relevant part of the log for gnome-session.schemas seems to be this:
> > 
> > revision 1.3
> > date: 2005/04/26 10:56:50;  author: carlosg;  state: Exp;  lines: +11 -0
> > 2005-04-26  Carlos Garnacho Parro  <carlosg gnome org>
> > 
> >         Fix for #76791
> > 
> >         * gnome-session.schemas.in: new key for handling default
> > selected
> >         option in the logout dialog
> >         * logout.c: implement option saving/restoring
> >         * headers.h: add the new key define
> > 
> > http://cvs.gnome.org/viewcvs/gnome-session/gnome-session/gnome-session.schemas.in?r1=1.2&r2=1.3
> > 
> > 
> > No warning had been given in advance for this addition. GNOME is in
> > string freeze, which means that prior announcement and approval of
> > string changes and string additions is needed, as described on
> > http://developer.gnome.org/dotplan/tasks.html#ApprovingFreezeBreaks.
> > 
> > I suggest that this change should be reverted from the string frozen
> > branch. If people disagree with that, then I would like to hear some
> > motivation on why this change is considered important enough to break
> > the freeze and why it cannot wait until the next development cycle.
> > 
> > Best regards
>