On Sat, 2004-09-04 at 01:02, Matthias Clasen wrote: > Looking at somewhat mysterious occasional panel crashes when saving > files in gedit, jrb and I discovered today that egg-recent isn't > threadsafe, since it installs a timeout which isn't protected by > GDK_THREADS_ENTER/_LEAVE. > While the fix is fairly trivial, the fact that it applies to a module > that has been copied all through Gnome makes fixing this a giant code > freeze break. We need release team approval to commit the attached patch > to libegg, and then all apps using egg-recent need to update their > copies. The alternative is unpredictable crashes from all multithreaded > apps using egg-recent (this includes all apps using gnome-vfs + egg- > recent). Not nice. This doesn't make a lot of sense to me ... is the panel really calling gdk_threads_init()? If not, the GDK_THREADS_ENTER/LEAVE will do nothing. Yes, we need the GDK_THREADS_ENTER/LEAVE in all libraries, but I wouldn't expect to have problems with most of the core GNOME apps. (Do we have any gdk_threads_init() apps in the desktop?) Regards, Owen
Attachment:
signature.asc
Description: This is a digitally signed message part