Re: battstat-applet testing, a plea for help



On Sat, 2004-05-22 at 12:51 +0200, Paolo Borelli wrote:

> As already suggested by Jan, you should NULLify the pointer after
> destroying the dialog.

Yes.

> Looking at the patch it also seems to me that you are leaking the
> new_label string when creating the dialog... beside gnome_*_dialog are
> deprecated and should be replaced with gtk_message_dialogs.

Hmm, I'm not intentionally leaking the label. I think that may have been
there a while now. I know about the deprecation of gnome_*_dialog-s,
however I haven't gotten around to changing them yet.
It will have to happen though.

--d

-- 
http://davyd.ucc.asn.au/
 
PGP Fingerprint <http://davyd.ucc.asn.au/pgp>
08B0 341A 0B9B 08BB 2118  C060 2EDD BB4F 5191 6CDA

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]