Re: battstat-applet testing, a plea for help



On Fri, 2004-05-21 at 01:49 +0800, Davyd Madeley wrote:
> GNOMErs,
> 
> battstat-applet from CVS (HEAD and gnome-2-6) now closed the warning
> dialog automatically when you plug your AC power in (a very cool
> feature).
> 
> However, it appears I introduced a segfault into it. I'm sure it's just
> a null reference, but it takes a long time to charge and discharge my
> battery to test it and hence, find it.
> 
> If someone could find it for me (and maybe even fix it) that would be
> great. Before it gets into 2.6.2 ;)
> 
> See bug http://bugzilla.gnome.org/show_bug.cgi?id=131322

As already suggested by Jan, you should NULLify the pointer after
destroying the dialog.

Looking at the patch it also seems to me that you are leaking the
new_label string when creating the dialog... beside gnome_*_dialog are
deprecated and should be replaced with gtk_message_dialogs.


ciao
	paolo




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]