Re: Enter the build sheriff: Jacob.



On Thu, 14 Mar 2002, Daniel Veillard wrote:

> On Thu, Mar 14, 2002 at 10:48:00AM -0500, jacob berkman wrote:
> > >   BUT, the build sheriff commited twice already without sending any mail
> > > informing me of the potential problem.
> > 
> > i checked HACKING and it said:
> > 
> >      In the exceptional case where a serious breakage in this module
> >     prevents other core projects from making progress, then feel free
> >     to patch first and send mail afterward as long as the changes are
> >     limited.
> >     
> > and in both cases this was true.
> 
>   Sorry, I didn't see the serious breakage, nor any complaint from 
> other core projects maintainers that this may have been broken [1].
> In both cases this was about python modules which may not have build in
> some circumstances.  No core project relies on those modules. I don't see
> either how this would have hampered the progresses of other modules. No
> really ...

This sounds as making building of the python bindings optional (and
defaulting to "no") would remove all the trouble. I fail to see a reason
for the python bindings to be in the gnome default (and much more so, in
the tinderbox) build. KNowing if/when they break gives IMVHO just about 0
bits of useful information.

>   This wording was there to allow really broken commits to get
> reverted/fixed in case they were seriously blocking other projects.
>   So I have 2 choices:
>    1/ forget about it hoping that you will send mail first in the future
>       in case the build break under some circumstances.
>    2/ disallow commits from non-maintainers (4 persons in gnome-xml,
>       3 persons in libxslt)
> 
>   I will do 1/ , 
> 
> Daniel
> 
> [1] actually James sent me a patch to apply to that part, I just didn't had
>     the time to look at it.
> 
> P.S.: You know, I suck. Too bad, live with it, you know I want a mail before
>       commits, it's not the first time, I hope it's the last.
> 
> -- 
> Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
> veillard redhat com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/desktop-devel-list
> 

	Sander

	I see a dark sail on the horizon
	Set under a dark cloud that hides the sun
	Bring me my Broadsword and clear understanding




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]