Re: [patch] Set save_selected from autosave

[jacob berkman <jacob ximian com>]

On Wed, 2002-06-05 at 20:32, Mark McLoughlin wrote:
> Hi Guys,
> 
> On 5 Jun 2002, jacob berkman wrote:
> 
> > On Tue, 2002-06-04 at 19:46, Gustavo Giráldez wrote:
> > > On Tue, 2002-06-04 at 16:01, jacob berkman wrote:
> > > > On Tue, 2002-06-04 at 14:30, Gustavo Giráldez wrote:
> > > > > [ ] prompt on logout
> > > > > [X] automatically save session
> > > > >
> > > > > so I do expect it to save my session.  In the situation you describe I
> > > > > don't have problems (i.e. session is not saved, so
> > > > > maybe_run_discard_commands is not run, so no session data is lost).
> > > >
> > > > ok, this patch isn't right then.
> > > >
> > > > does the attached patch work for you?
> > > >
> > >
> > > The attached patch does what I expect, yes (tested in all four
> > > combinations of the two keys).
> >
> > ok, i've committed it to CVS.
> 
> 	Thanks guys - my bad for not testing the DiscardCommand stuff
> with autosave.

it's easier to just blame the large number of
not-all-that-well-documented global variables ;)

i was kind of relieved when i found out this bug was introduced in the
last week, though. 

 - jacob