Re: [patch] Set save_selected from autosave

[Gustavo Giráldez <gustavo giraldez gmx net>]

On Tue, 2002-06-04 at 16:01, jacob berkman wrote:
> On Tue, 2002-06-04 at 14:30, Gustavo Giráldez wrote:
> > [ ] prompt on logout
> > [X] automatically save session
> > 
> > so I do expect it to save my session.  In the situation you describe I
> > don't have problems (i.e. session is not saved, so
> > maybe_run_discard_commands is not run, so no session data is lost).
> 
> ok, this patch isn't right then.
> 
> in manager.c:maybe_write_session(), you can see that it checks autosave
> || save_selected before writing the session.

Right, the problem is not there.  In fact write session is saved and the
session saving code is executed.  The problem is in
maybe_run_discard_commands (manager.c:1324).

   if (discard && shutting_down && !save_selected)
     run_command_prop (client, SmDiscardCommand, discard);

See, if you got there because autosave was true, but save_selected is
false, the new discard command is executed.  I don't know why the new
command discarded in the first place, probably some state transition I'm
not seeing.  Maybe the fix should go there instead of in
maybe_display_gui?

> 
> does the attached patch work for you?
> 

The attached patch does what I expect, yes (tested in all four
combinations of the two keys).

HTH,
Gustavo