Re: [patch] Set save_selected from autosave

[Gustavo Giráldez <gustavo giraldez gmx net>]

On Tue, 2002-06-04 at 12:52, jacob berkman wrote: 
> On Tue, 2002-06-04 at 06:36, Gustavo Giráldez wrote:
> > Hi,
> > 
> > The attached patch set save_selected in maybe_display_gui.  This is
> > necessary for saving the session when the option prompt on logout is
> > unchecked, since otherwise in maybe_run_discard_commands the new discard
> > command is run, and of course it erases the currently saved data.
> 
> so gnome-session-properties has this for you in the first tab:
> 
> [ ] prompt on logout
> [ ] automatically save session
> 
> ?
> 
> and, are you expecting it to save your session?

Err... no.  I have: 

[ ] prompt on logout
[X] automatically save session

so I do expect it to save my session.  In the situation you describe I
don't have problems (i.e. session is not saved, so
maybe_run_discard_commands is not run, so no session data is lost). 

If automatically save session is checked (no matter if prompt is set or
not), the save session code is run at logout time but save_selected is
not set, resulting in both discard commands, old and new, being run. 
The annoying thing about this (besides not being the correct behavior
imho) is that metacity's session file is deleted, so next time I log in,
metacity doesn't know its previous session id (stored in the session
file), and then it can't register to the SM.  Because of this, the SM
hangs until purge_delay is expired, which is about 30 sec (I think),
because it's waiting for a client to register with the previous session
id.

Sorry, I really don't know how to explain this better (my English
vocabulary is limited).  I hope it's more clear now.

Regards,
Gustavo