Re: having a crash-on-exit when closing control-center



On Thu, 2002-01-24 at 16:58, Mikael Hallendal wrote:
> Hi!
> 
> Everytime I close the control-center after clicking on one of the
> capplets I get a segfault. The attached patch fixes this. Is it ok to
> commit?

It seems that the "&& &style" part is superfluous, but otherwise it
looks fine. Please commit. Thanks.

> Regards, 
>   Mikael Hallendal
> 
> -- 
> Mikael Hallendal                micke codefactory se
> CodeFactory AB                  http://www.codefactory.se/
> Office: +46 (0)8 587 583 05     Cell: +46 (0)709 718 918
> ----
> 

> --- control-center/capplet-manager.c.orig	Thu Jan 24 21:57:56 2002
> +++ control-center/capplet-manager.c	Thu Jan 24 21:58:01 2002
> @@ -323,7 +323,10 @@
>                  close_capplet (TRUE, nd);
>                  nd->state = CAPPLET_INACTIVE;
>                  style = gtk_widget_get_style (GTK_WIDGET (nd->ctree));
> -                gtk_ctree_node_set_foreground (nd->ctree, nd->node, &style->fg[GTK_STATE_NORMAL]);
> +
> +                if (style && &style) {
> +                        gtk_ctree_node_set_foreground (nd->ctree, nd->node, &style->fg[GTK_STATE_NORMAL]);
> +                }
>          }
>  }
>  static void
-- 
========================================================================
Bradford Hovinen                                                  Hacker
http://www.cis.udel.edu/~hovinen/                    Ximian Desktop team
hovinen ximian com                                          Ximian, Inc.

Now what is history? It is the centuries of systematic explorations of
the riddle of death, with a view to overcoming death. That's why people
discover mathematical infinity and electromagnetic waves, that's why
they write symphonies.
                                      - Boris Pasternak, Doctor Zhivago

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]