Re: [Deskbar] Twitter handler, and tricks for web-app modules

[Sebastian Pölsterl <marduk k-d-w org>]

Mikkel Kamstrup Erlandsen schrieb:
> Hi list, a good while since I have been around here. Sorry for that :-)
>
> I recently did a massvie update of the old Twitter handler. See here:
> http://www.grillbar.org/wordpress/?p=276. Actual code here:
> http://grillbar.org/files/twitter.py
>
> I would like to submit it for general inclusion in deskbar. There is a few
> things I would like to change before I do that though.
>
> If you look at the actual code you will find a few things that might be very
> handy for other web-app based modules:
>
>  * Embedded base64 icon loading. I suggest moving a version of my
> load_base64_icon() to deskbar.core.Utils. This makes it easily possible to
> ship custom icons embedded directly in your python scripts.
Great idea. This is very useful, especially for the upcoming OpenSearch 
module [1].

>  * The Account, AccountDialog, and GnomeURLopener. These are classes that
> integrates Gnome Keyring with urllib (for username/pass retrieval) as well
> as doing async http communication (I need to do async POSTs in the
> Action.activate()). I suggest I put this in a new Python module
> deskbar.core.Web or something.
In the source code you say that the code is from 
http://www.rittau.org/blog/20070726-00, but I couldn't find any code on 
this page. Nevertheless, we should make sure that the author is okay 
with it (to include it in Deskbar).

Nevertheless, the idea is great. I'd love to see an AccoundDialog class 
that you can easily modify to display the fields someone want to see in 
such a dialog. Maybe we should discuss in detail what such a class 
should be capable of.

Because you're doing much with threads in this area I was wondering if 
it's actually safe that no dead locks appear. I know threading and GTK+ 
can drive you crazy easily. Is it really necessary to use threads?

When you try to make a connection to the internet you have to catch 
IOError and abort when something goes wrong. Otherwise, user's that 
don't have an internet connection will see bug buddy all the time.

[1]: http://bugzilla.gnome.org/show_bug.cgi?id=528184

--
Greetings,
Sebastian Pölsterl