Re: [Deskbar] Code freeze break for deskbar-applet

["Elijah Newren" <newren gmail com>]

On 9/3/06, Raphaël Slinckx <raphael slinckx net> wrote:
> On Fri, 2006-09-01 at 18:24 +0200, Raphaël Slinckx wrote:
> > Hi !
> >
> > I'm sorry to ask a code freeze break for deskbar, we have received a lot
> > of crashers thanks to the new bug buddy integration system, and we would
> > like to fix the most importants before the final release happens.
>
> And one more:
> Bug: http://bugzilla.gnome.org/show_bug.cgi?id=354014
> Patch: http://bugzilla.gnome.org/attachment.cgi?id=72094
>
> Fix a problem when the 'search selection' feature is enabled because of
> a method and a variable being named the same.
>
> I took the liberty to commit those 4 trivial fixes plus a a build fix,
> because nobody replied here, the release deadline is tomorrow and i
> pinged like a mad on IRC. Also deskbar would have been so broken i would
> be ashamed of it. I hope this didn't cause too much trouble.

Sorry for being slow to respond.  I'm trying to catch up on
everything.  I would have preferred you waiting a bit longer or only
applying the ones that are critical, but I do understand with it being
so close to tarball due deadline.  So, my comments:

Bug 353526 & Bug 353674
Both are crashers and things couldn't get much worse.  Patches look
short, which is also a bonus.  I think getting these committed are the
right thing to do.  1 of 2 (retroactive) approvals.  ;-)

Bug 353605
I don't see how this is release critical, though it's possible I'm
misunderstanding the bug.  It just looks like a minor cosmetic
problem, and as such something that we should not break freeze for,
especially so late.  While the patch is very simple, I'd still prefer
it were reverted unless this actually causes a severe usability issue.

Bug 354014
Does this cause any severe issues?  I know the patch is simple, but
being so late into code freeze I really don't like seeing changes like
this.  Can you explain more about the user impact before releasing
with this patch?

Thanks for all your work.  Sorry we've been so slow to get back to you.

Elijah