Proposal patch for bug #780986 (Unmount server after backup)

Hi everyone,

I have attached a patch that could deal with this bug:

Regarding the bug itself, I understand that Deja-Dup should not unmount a share if a user is browsing it or even just if a user expects the remote share to be mounted, so the changes I propose deal with this making Deja-Dup trying to unmount the share only if it has been explicitly mounted by Deja-Dup in order to perform the backup (or any other operation).

The patch introduces a new backend method 'clean_up()' that gets called at the end of the Verify operation. This method would take care of any kind of backend tear down, that in the case of remote backends means to try unmounting the remote if it has been explicitly mounted.

Given that I have no experience with Deja-Dup's codebase or Vala (just a tiny one-line bugfix for elementary Os' Calendar :P ) I don't expect this patch to be accepted. Maybe even the strategy I propose is not good enough. Anyway, I am open to ideas and suggestions.

Jordi Chulia

Attachment: unmount_after_backup.patch
Description: Text Data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]