Re: Audio Tag proposed layout

[Veerapuram Varadhan <vvaradhan novell com>]

On Wed, 2004-11-03 at 14:01 +0100, Rapha�Slinckx wrote:
> Hi !
> 
> Here is a layout I propose for the Music tag reading in beagle:
> What do you think about it ?
> 
> > beagle/Filters
> >       FilterMusic.cs (Parent abstract class for music tags, define a
> method for updating properties with the given tag)
> >       FilterMp3.cs (Each format has its own handler class file,
> derived from FilterMusic class)
> >       FilterOgg.cs (it reads the file, and sends the Tag to the
> parent method to update properties)
> >       FilterApe.cs
> >       .
> >       .
> >       .
> >       .

This looks OK to me than the below one for a simple reason that I will
get to know *easily* the list of *audio file formats* supported by
beagle.

> >       OR
> >       FilterMusic.cs (a single file contains all of the
> above         
> > beagle/Util/AudioUtil
> >       Beagle.Util.AudioUtil
> >                       Tag.cs (a unified tag for every tag format)
> >                       Mp3Reader.cs (the XXX format reader, get a
> Stream, returns a Tag)
> >                       ApeReader.cs
> >                       .       
> >                       .
> >                       .
> >                       Utils.cs (various common static methods)
> 

On the other hand, this will abstract the *reader* part from the
Filters.  Probably this approach is fine, especially when we use
external libraries/packages in our filters.

I will go with "second approach"!!
--
V. Varadhan.