Re: bugzilla validation

On Sat, 2004-01-03 at 18:34, David Stahl wrote:
> This is my first patch so feel free to criticize style or approach :)

Being a style nazi, the patch should conform to the existing coding
style.  That is, spaces after just about everything:

"if (...)" not "if(...)"

"function (...)" not "function(...)"

"} catch {" not "}catch{"


Aside from that, the patch functionally looks fine to me, but I don't
know all the neat .NET XML tricks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]