[gnome-builder] libide/io: dont allow using fish as compatible shell

[Christian Hergert <chergert src gnome org>]

commit 03f85ddfb7b3f5f033ad8956d0637c0dfb9af2ca
Author: Christian Hergert <chergert redhat com>
Date:   Thu Sep 29 20:46:48 2022 -0700

    libide/io: dont allow using fish as compatible shell
    
    It appears to cause some issues as we use shells to pass work between
    container layers. So instead just fallback to `sh -l -c ''` as we can
    be reasonably sure that will work as expected.

 src/libide/io/ide-shell.c | 8 ++++++++
 1 file changed, 8 insertions(+)
---
diff --git a/src/libide/io/ide-shell.c b/src/libide/io/ide-shell.c
index 77b9224fb..79d535c24 100644
--- a/src/libide/io/ide-shell.c
+++ b/src/libide/io/ide-shell.c
@@ -36,7 +36,13 @@ ide_shell_supports_dash_c (const char *shell)
     return FALSE;
 
   return strcmp (shell, "bash") == 0 || g_str_has_suffix (shell, "/bash") ||
+#if 0
+         /* Fish does apparently support -l and -c in testing, but it is causing
+          * issues with users, so we will disable it for now so that we fallback
+          * to using `sh -l -c ''` instead.
+          */
          strcmp (shell, "fish") == 0 || g_str_has_suffix (shell, "/fish") ||
+#endif
          strcmp (shell, "zsh") == 0 || g_str_has_suffix (shell, "/zsh") ||
          strcmp (shell, "dash") == 0 || g_str_has_suffix (shell, "/dash") ||
          strcmp (shell, "tcsh") == 0 || g_str_has_suffix (shell, "/tcsh") ||
@@ -60,7 +66,9 @@ ide_shell_supports_dash_login (const char *shell)
     return FALSE;
 
   return strcmp (shell, "bash") == 0 || g_str_has_suffix (shell, "/bash") ||
+#if 0
          strcmp (shell, "fish") == 0 || g_str_has_suffix (shell, "/fish") ||
+#endif
          strcmp (shell, "zsh") == 0 || g_str_has_suffix (shell, "/zsh") ||
          strcmp (shell, "dash") == 0 || g_str_has_suffix (shell, "/dash") ||
 #if 0