[gnome-software/1930-app-page-broken-ratings-card-empty-state] gs-details-page: Hide review histogram part when it's empty
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1930-app-page-broken-ratings-card-empty-state] gs-details-page: Hide review histogram part when it's empty
- Date: Thu, 29 Sep 2022 10:31:52 +0000 (UTC)
commit 5a1fcb7b4fb5ce831cb3362601ecfea4e004bce4
Author: Milan Crha <mcrha redhat com>
Date: Thu Sep 29 12:29:28 2022 +0200
gs-details-page: Hide review histogram part when it's empty
When the review histogram part is empty, which can happen when no ratings
are downloaded and there's no review button to be shown, the corresponding
listbox was empty, causing and odd view on the reviews part.
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1930
src/gs-details-page.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 50b80e159..b1839ae03 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1573,11 +1573,13 @@ gs_details_page_refresh_reviews (GsDetailsPage *self)
gtk_widget_set_visible (self->list_box_featured_review, reviews->len > 0);
/* Update the overall container. */
- gtk_widget_set_visible (self->box_reviews,
+ gtk_widget_set_visible (self->list_box_reviews_summary,
show_reviews &&
(gtk_widget_get_visible (self->histogram_row) ||
- gtk_widget_get_visible (self->button_review) ||
- reviews->len > 0));
+ gtk_widget_get_visible (self->button_review)));
+ gtk_widget_set_visible (self->box_reviews,
+ reviews->len > 0 ||
+ gtk_widget_get_visible (self->list_box_reviews_summary));
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]