[gnome-software/wip/notify-pending-updates] gs-utils: Online update should not reset update-notification-timestamp



commit 58079e9f1c15d5ee19d8dd736fa3c288ec717cde
Author: Milan Crha <mcrha redhat com>
Date:   Thu Sep 8 17:38:37 2022 +0200

    gs-utils: Online update should not reset update-notification-timestamp
    
    This had been added in commit 70be111a7fe4c36a874a7af39226df8a786d87e2,
    fix for https://gitlab.gnome.org/GNOME/gnome-software/-/issues/947 .
    Its side effect is when there are pending offline updates, but before
    the code gets to notify about them there are made online updates,
    the notification is hidden and the user doesn't know there are
    pending updates.

 lib/gs-utils.c | 6 ------
 1 file changed, 6 deletions(-)
---
diff --git a/lib/gs-utils.c b/lib/gs-utils.c
index 73743008e..2c3fb5be7 100644
--- a/lib/gs-utils.c
+++ b/lib/gs-utils.c
@@ -1167,10 +1167,6 @@ gs_utils_get_memory_total (void)
  *
  * Sets the value of online-updates-timestamp to current epoch. "online-updates-timestamp" represents
  * the last time the system was online and got any updates.
- *
- * It also sets the "update-notification-timestamp", to not receive
- * notifications about available updates too early after the actual
- * update happened.
  **/
 void
 gs_utils_set_online_updates_timestamp (GSettings *settings)
@@ -1181,8 +1177,6 @@ gs_utils_set_online_updates_timestamp (GSettings *settings)
 
        now = g_date_time_new_now_local ();
        g_settings_set (settings, "online-updates-timestamp", "x", g_date_time_to_unix (now));
-
-       g_settings_set (settings, "update-notification-timestamp", "x", g_date_time_to_unix (now));
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]