[nautilus/wip/antoniof/properties-fixes: 2/3] image-properties: Actually show failure info

[António Fernandes <antoniof src gnome org>]

commit 6168d0449839e0b32260e722f973409cb7327ad3
Author: António Fernandes <antoniof gnome org>
Date:   Wed Sep 7 11:24:36 2022 +0100

    image-properties: Actually show failure info
    
    We ask to append a failure message with NULL value, and then don't
    actually append it because of the value being NULL. This makes no
    sense, so fix it.
    
    Despite that, in order to improve visuals, move the failure message
    to the value and use an existing generic error string as title.

 extensions/image-properties/nautilus-image-properties-model.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/extensions/image-properties/nautilus-image-properties-model.c 
b/extensions/image-properties/nautilus-image-properties-model.c
index 24e579bda..930a910e9 100644
--- a/extensions/image-properties/nautilus-image-properties-model.c
+++ b/extensions/image-properties/nautilus-image-properties-model.c
@@ -64,10 +64,7 @@ append_item (NautilusImagesPropertiesModel *self,
     g_autoptr (NautilusPropertiesItem) item = NULL;
 
     item = nautilus_properties_item_new (name, value);
-    if (value != NULL)
-    {
-        g_list_store_append (self->group_model, item);
-    }
+    g_list_store_append (self->group_model, item);
 }
 
 static void
@@ -240,7 +237,7 @@ load_finished (NautilusImagesPropertiesModel *self)
     }
     else
     {
-        append_item (self, _("Failed to load image information"), NULL);
+        append_item (self, _("Oops! Something went wrong."), _("Failed to load image information"));
     }
 
     if (self->loader != NULL)