[gtksourceview] solarized: use error underline for def:error
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtksourceview] solarized: use error underline for def:error
- Date: Tue, 6 Sep 2022 23:07:52 +0000 (UTC)
commit 5f629591a3cbbc15d20f1eae66d362dbc1eba033
Author: Christian Hergert <chergert redhat com>
Date: Tue Sep 6 16:07:47 2022 -0700
solarized: use error underline for def:error
Using a bold red color for errors might have matched the original styles
of Solarized when it was captive to a terminal, but it does not very much
match modern IDEs and editors when it comes to what the pango renderer
can do.
Instead, use the expected error styling but color to match the Solarized
palette.
data/styles/solarized-dark.xml | 2 +-
data/styles/solarized-light.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/data/styles/solarized-dark.xml b/data/styles/solarized-dark.xml
index 938a62b1..17d173e1 100644
--- a/data/styles/solarized-dark.xml
+++ b/data/styles/solarized-dark.xml
@@ -120,7 +120,7 @@
<!-- Others -->
<style name="def:preprocessor" foreground="violet"/>
- <style name="def:error" foreground="red" bold="true"/>
+ <style name="def:error" underline="error" underline-color="red"/>
<style name="def:note" foreground="magenta" bold="true"/>
<style name="def:net-address" italic="true" underline="single"/>
diff --git a/data/styles/solarized-light.xml b/data/styles/solarized-light.xml
index 66e60ccf..98920f3a 100644
--- a/data/styles/solarized-light.xml
+++ b/data/styles/solarized-light.xml
@@ -121,7 +121,7 @@
<!-- Others -->
<style name="def:preprocessor" foreground="violet"/>
- <style name="def:error" foreground="red" bold="true"/>
+ <style name="def:error" underline="error" underline-color="red"/>
<style name="def:note" foreground="magenta" bold="true"/>
<style name="def:net-address" italic="true" underline="single"/>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]