[gnome-sound-recorder/ebassi/experiments: 8/8] Fix the close_request vfunc implementation




commit 0e7348a6a3015d32f9ff9bbf34af2b8efe41d133
Author: Emmanuele Bassi <ebassi gnome org>
Date:   Mon Aug 15 18:16:37 2022 +0100

    Fix the close_request vfunc implementation
    
    GtkWindowClass.close_request() returns a boolean value:
    
    - true, for stopping the signal emission
    - false, for continuing the signal emission
    
    The default behaviour when closing a window is to destroy it, which will
    terminate the application instance.
    
    The lack of a return value was masked by the explicit call to
    GApplication.quit(), which forcibly terminates the application in the
    following main loop iteration.

 src/window.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/window.js b/src/window.js
index d224d47..7bb7cab 100644
--- a/src/window.js
+++ b/src/window.js
@@ -101,7 +101,7 @@ var Window = GObject.registerClass({
         }
 
         this.recorder.stop();
-        this.application.quit();
+        return false;
     }
 
     onRecorderStarted() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]